On Wed, 19 Oct 2022 13:03:53 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
> Looks fine. Curious, how well are all these alignments tested? E.g. do they
> work with all GCs?
I tested `serviceability/sa` with default (G1) and all acceptable alignments,
seems to work fine. We can run the tests with other GCs, if anyone wants it.
> test/hotspot/jtreg/serviceability/sa/TestObjectAlignment.java line 84:
>
>> 82: SATestUtils.skipIfCannotAttach(); // throws SkippedException if
>> attach not expected to work.
>> 83: if (args == null || args.length == 0) {
>> 84: for (int align = 8; align <= 256; align *= 2) {
>
> Alternatively, no loop, six test sections, hand in alignment via program arg,
> and be able to do all this in parallel?
The test seems short, so I opted for simplicity.
-------------
PR: https://git.openjdk.org/jdk/pull/10762
