> The main issues I set out to address are:
> 
> - legacy Solaris references can be removed
> - add help with dealing with Windows core files, most of important of which 
> is use of PATH to find the dlls referenced by the core file.
> - add help with dealing with macOS core files, most of important of which is 
> using JAVA_HOME or DYLD_LIBRARY_PATH to find the dlls referenced by the core 
> file. 
> 
> However, in the end it turned out to be a pretty substantial restructuring 
> and rewrite.
> 
> Here are links to the rendered old and new copies of the file:
> [old 
> file](https://htmlpreview.github.io/?https://github.com/openjdk/jdk/blob/master/src/jdk.hotspot.agent/doc/transported_core.html)
> [new file 
> rev1](https://htmlpreview.github.io/?https://github.com/openjdk/jdk/blob/6778a202a855a534754c4b47a6cd99cb912869d3/src/jdk.hotspot.agent/doc/transported_core.html)
> [new file 
> rev2](https://htmlpreview.github.io/?https://github.com/openjdk/jdk/blob/7448593f0a9142e5d99844f349b4d54819735540/src/jdk.hotspot.agent/doc/transported_core.html)
> [new file 
> rev3](https://htmlpreview.github.io/?https://github.com/openjdk/jdk/blob/ce5c808ca5af4e551bf78d593d865a1f228ad950/src/jdk.hotspot.agent/doc/transported_core.html)
> [new file 
> rev4](https://htmlpreview.github.io/?https://github.com/openjdk/jdk/blob/3b16e560499eb526d283a9c16531cc1c3f63394e/src/jdk.hotspot.agent/doc/transported_core.html)

Chris Plummer has updated the pull request incrementally with one additional 
commit since the last revision:

  some minor edits

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10518/files
  - new: https://git.openjdk.org/jdk/pull/10518/files/ce5c808c..3b16e560

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10518&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10518&range=02-03

  Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/10518.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10518/head:pull/10518

PR: https://git.openjdk.org/jdk/pull/10518

Reply via email to