On Thu, 6 Oct 2022 07:16:44 GMT, Dmitry Samersoff <dsamers...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> addressed review comments about is_JavaThread_current and @enablePreview >> tag > > src/hotspot/share/prims/jvmtiEnvBase.hpp line 180: > >> 178: JavaThread* current = JavaThread::current(); >> 179: oop cur_obj = current->jvmti_vthread(); >> 180: bool is_current = jt == current && (cur_obj == NULL || cur_obj == >> thr_obj); > > It might be better to restructure this "if" and check for jt==current before > we ask for cur_obj, or at least add brackets. Thank you for the comment. I've refactored it a little bit. Please, let me know if you agree with it. ------------- PR: https://git.openjdk.org/jdk/pull/10586
