On Tue, 20 Sep 2022 00:36:38 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> The Thread.suspend/resume is replaced by JVM TI SuspendThread/ResumeThread >> whether it is possible. >> Testcase from test >> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/interrupt/interrupt001.java >> was removed because only one environment can suspend threads so debugger is >> not compatible with JVM TI agent suspending test. >> >> Test test/hotspot/jtreg/runtime/handshake/HandshakeSuspendExitTest.java >> starts failing because it got JVMTI_ERROR_INTERNAL. The problem is that >> JvmtiSuspendControl::resume() returned false. However, it might happen only >> if the thread is not suspended, which means that it should be >> JVMTI_ERROR_THREAD_NOT_SUSPENDED. > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > revert changes Hi Leonid, This looks good in general. I've added a couple of comments though. The PR title does not match the bug title: com/sun/jdi vs hotspot/jtreg. Thanks, Serguei ------------- PR: https://git.openjdk.org/jdk/pull/10351
