On Tue, 13 Sep 2022 23:51:03 GMT, Mandy Chung <mch...@openjdk.org> wrote:
> The change looks good. There are other tests that reference `ThreadDeath` for > example `test/lib/jdk/test/lib/process/ProcessTools.java`, > `test/jdk/java/util/Timer/KillThread.java` , > `test/jdk/java/net/httpclient/reactivestreams-tck/org/reactivestreams/tck/flow/support/NonFatal.java` > etc. Is it expected to update them in a follow-on issue? I've been trying to keep the test cleanup separate if possible, only because the changes become unwieldy. Aside from jshell, the tests that used Thread.stop have already been changed or removed in advance of this PR. The tests that have catch blocks for ThreadDeath will work as before as there is no Thread.stop. There are one or two tests that will need special attention - the reactivestreams-tck tests that you listed is 3rd party code and we might decide to do nothing there. ------------- PR: https://git.openjdk.org/jdk/pull/10230
