On Fri, 9 Sep 2022 09:28:38 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> Test update to cope with heap size changing (shrinking) in the early life of >> the test app. >> >> A change in GC timing affects this test which reads eden size and heap size. >> Both eden and heap are likely to shrink initially for this test. Failures >> were that heap size shrank after reading eden size, such that eden appeared >> to be >100% of heap. >> Recognising a shrinking heap and retrying resolves this. >> >> (Re-ordering to read heap size then eden would be enough to make the check >> in provokeGc work. But it would allocate sometimes a very small fraction of >> the heap, which is not the intent.) > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > Clarify that loop is for checking heap not changing. Exception if > continually changing. I think the point is that the loop has been there probably since the beginning. So I wouldn't take it out. However, I'm not sure I agree with how you have now moved some parts out of the loop so they are only done once. ------------- PR: https://git.openjdk.org/jdk/pull/10218
