On Wed, 7 Sep 2022 22:06:11 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
> Looks good. Thanks. > Also noticed some pre-existing unnecessary (void*) casts of the pointer > argument to p2i. Not your problem, and not really appropriate for this change > to do anything about them, but I really hate eye-catching cast junk like that. I agree. I cleaned out some of that. There's a lot of casts from `oop` to `void*` that are unnecessary after we rewrote the fastdebug oop class and/or `p2i`. > > There were also a few INTPTR_FORMAT uses that were left in place. All that I > recall looked like they could/should instead be SIZE_FORMAT_X_0 or maybe even > SIZE_FORMAT_X if the zero padding isn't useful. Leaving those for a later > pass seems fine. I wonder how many INTPTR_FORMATs are left in the areas you > worked on? I saw a lot of intptr_t/uintptr_t being printed with INTPRT_FORMAT, I don't think those should be changed to use SIZE_FORMAT_. I found and converted three more lingering INTPTR_FORMAT usages. We are now down to a little bit less then 30 usages of INTPTR_FORMAT in the directories relevant to this PR. Most in: g1HeapRegionAttr.hpp to print an index elfFile.hpp to print a integer typed address markWord.cpp to print the mark word stackChunk/instanceStackChunk files to print relative stack pointers ------------- PR: https://git.openjdk.org/jdk/pull/10141
