On Fri, 26 Aug 2022 12:04:57 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:

>> There seems to be a case where utf_util.c getWideString might leak memory in 
>> an early return.
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Introduce UTF_WARNING and use the fallback

src/jdk.jdwp.agent/share/native/libjdwp/utf_util.c line 339:

> 337:     *pwlen = wlen;
> 338:     if (wlen <= 0) {
> 339:         UTF_WARNING(("Can't get WIDE string length"));

If you are changing this to a warning then it should probably be limited to the 
NO_UNICODE_TRANSLATION case, I think you still want to abort if it fails due to 
invalid flags or parameters or buffer issue as that would a JDK (or Windows) 
bug.

-------------

PR: https://git.openjdk.org/jdk/pull/9918

Reply via email to