On Mon, 18 Jul 2022 20:04:14 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Fix a bug
>
> src/hotspot/share/prims/jvmtiTagMap.cpp line 1223:
> 
>> 1221:       MonitorLocker ml(lock(), Mutex::_no_safepoint_check_flag);
>> 1222:       // If another thread is posting events, let it finish
>> 1223:       bool posting = _posting_events;
> 
> Should this be volatile or use OrderAccess::load_acquire() so it's reread?

No, setting and reading `_posting_events` are done under lock, so it is safe.

-------------

PR: https://git.openjdk.org/jdk/pull/9168

Reply via email to