On Wed, 13 Jul 2022 16:55:38 GMT, Ichiroh Takiguchi <itakigu...@openjdk.org> 
wrote:

> AIX build was failed by following messages:
> 
> * For target hotspot_variant-server_libjvm_objs_BUILD_LIBJVM_link:
> ld: 0711-317 ERROR: Undefined symbol: collector_func_load
> ld: 0711-317 ERROR: Undefined symbol: .collector_func_load
> ld: 0711-344 See the loadmap file 
> /home/jdkbld/git/jdk/build/aix-ppc64-server-release/hotspot/variant-server/libjvm/objs/libjvm.loadmap
>  for more information.
> 
> In my investigation, 
> [JDK-8289780](https://bugs.openjdk.org/browse/JDK-8289780) affects this issue 
> on src/hotspot/share/prims/forte.cpp.

Changes requested by iklam (Reviewer).

src/hotspot/share/prims/forte.cpp line 670:

> 668: // Because it is weakly bound, the calls become NOP's when the library
> 669: // isn't present.
> 670: #if defined(__APPLE__)

I think this can be combined with the condition below:


#if defined(__APPLE__) || defined(_AIX)


I am curious why `collector_func_load` worked before but 
`collector_func_load_enabled()` doesn't work, since they are using the same 
pattern. Anyway, I think the new change is better, since the profiling tool 
that requires `collector_func_load` isn't available on AIX.

-------------

PR: https://git.openjdk.org/jdk/pull/9482

Reply via email to