On Sat, 9 Jul 2022 17:21:08 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adjusted max number of threads instead of adding explicit timeout
>
> test/hotspot/jtreg/serviceability/jvmti/events/FramePop/framepop02/libframepop02.cpp
> line 219:
>
>> 217:
>> 218: if (!isTestThread(jni, jvmti, thr)) {
>> 219: return; // not a tested thread
>
> If I read the test correctly, NotifyFramePop will only be called with the
> test thread so therefore the FramePop callback should only be called by the
> test thread, is that correct? I'm asking because I'm wondering why FramePop
> also checks the thread is the test thread.
As I understand, it is kind of a double-check in this test.
I agree, we can simplify this code little bit.
-------------
PR: https://git.openjdk.org/jdk19/pull/129
