On Thu, 12 Nov 2026 06:52:53 GMT, Shawn Emery <[email protected]> wrote:
> > I'm still seeing this failure on macosx-aarch64-debug: > > ``` > > class = sun.security.provider.SHA3Parallel > > method = quadKeccak > > TestInvoke Error: > > expected = 0 > > actual = 1 > > ----------System.err:(17/1127)---------- > > java.lang.Exception: Exception: java.lang.Exception: TestInvoke Error > > at compiler.intrinsics.sha.TestInvoke.testInvoke(TestInvoke.java:98) > > ``` > > ... > > I believe that this is expected behavior before the fix for JDK-8397115. The fix is merged now, so this failure should be gone. > test/hotspot/jtreg/compiler/intrinsics/sha/TestInvoke.java line 26: > >> 24: /** >> 25: * @test >> 26: * @bug 8396624 > > Since this bug ID does not test for a particular defect in the JDK itself > then I believe that you can omit this annotation. How about using [JDK-8386578](https://bugs.openjdk.org/browse/JDK-8386578) instead? > test/hotspot/jtreg/compiler/intrinsics/sha/TestInvoke.java line 45: > >> 43: import java.lang.reflect.Method; >> 44: >> 45: public class TestInvoke { > > Since this is specific to SHA3Parallel the class name should reflect that, > e.g. TestSHA3Parallel. I'd like to keep the name generic, so future methods outside SHA3Parallel can use it. > test/hotspot/jtreg/compiler/intrinsics/sha/sanity/InvokeSanityTestBase.java > line 39: > >> 37: * Base class for sanity tests on SHA intrinsic invocations. >> 38: */ >> 39: public class InvokeSanityTestBase { > > Since this is specific to SHA3Parallel the class name should reflect that, > e.g. SHA3ParallelTestBase. I'd like to keep the name generic, so future methods outside SHA3Parallel can use it. > test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA1Intrinsics.java > line 41: > >> 39: * -XX:CompileOnly=sun.security.provider.DigestBase::* >> 40: * -XX:CompileOnly=sun.security.provider.SHA::* >> 41: * -XX:+UseSHA1Intrinsics -Dalgorithm=SHA-1 > > I don't think that this file should be changing. These changes are reverted now. > test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA256Intrinsics.java > line 41: > >> 39: * -XX:CompileOnly=sun.security.provider.DigestBase::* >> 40: * -XX:CompileOnly=sun.security.provider.SHA2::* >> 41: * -XX:+UseSHA256Intrinsics -Dalgorithm=SHA-224 > > I don't think that this file should be changing. These changes are reverted now. > test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA3Intrinsics.java > line 43: > >> 41: * -XX:CompileOnly=sun.security.provider.SHA3::* >> 42: * -XX:+IgnoreUnrecognizedVMOptions >> -XX:+UseSIMDForSHA3Intrinsic >> 43: * -XX:+UseSHA3Intrinsics -Dalgorithm=SHA3-224 > > I don't think that this file should be changed. These changes are reverted now. > test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA3ParallelIntrinsics.java > line 26: > >> 24: /** >> 25: * @test >> 26: * @bug 8396624 > > Since this bug ID does not test for a particular defect in the JDK itself > then I believe that you can omit this annotation. How about using [JDK-8386578](https://bugs.openjdk.org/browse/JDK-8386578) instead? > test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA512Intrinsics.java > line 41: > >> 39: * -XX:CompileOnly=sun.security.provider.DigestBase::* >> 40: * -XX:CompileOnly=sun.security.provider.SHA5::* >> 41: * -XX:+UseSHA512Intrinsics -Dalgorithm=SHA-384 > > I don't believe that this file should be changed. These changes are reverted now. ------------- PR Comment: https://git.openjdk.org/jdk/pull/33709#issuecomment-6840563047 PR Review Comment: https://git.openjdk.org/jdk/pull/33709#discussion_r4558359245 PR Review Comment: https://git.openjdk.org/jdk/pull/33709#discussion_r4558385659 PR Review Comment: https://git.openjdk.org/jdk/pull/33709#discussion_r4558383840 PR Review Comment: https://git.openjdk.org/jdk/pull/33709#discussion_r4558366863 PR Review Comment: https://git.openjdk.org/jdk/pull/33709#discussion_r4558366093 PR Review Comment: https://git.openjdk.org/jdk/pull/33709#discussion_r4558395904 PR Review Comment: https://git.openjdk.org/jdk/pull/33709#discussion_r4558357007 PR Review Comment: https://git.openjdk.org/jdk/pull/33709#discussion_r4558395399
