> The primary reason for this set of changes is to sanity check the 
> **doubleKeccak** and **quadKeccak** methods. This includes their intrinsified 
> and pure Java variants. The new JTREG source files listed below essentially 
> validate return values from invoked private methods using the Java Reflection 
> API.
> 
> 1. `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/TestInvoke.java`
> 2. 
> `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/sanity/InvokeSanityTestBase.java`
> 3. 
> `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA3ParallelIntrinsics.java`
> 
> Additionally, the multi block intrinsic tests now check the correct 
> **implCompressMultiBlock0** method. All modifications and tests used [OpenJDK 
> v28-b22](https://github.com/openjdk/jdk/releases/tag/jdk-28%2B22) as the 
> baseline build.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Mohamed Issa has updated the pull request with a new target base due to a merge 
or a rebase. The pull request now contains 14 commits:

 - Revert changes to files that aren't functionally required.
 - Merge tag 'jdk-28+24' into user/missa-prime/crypto
   
   Added tag jdk-28+24 for changeset f06e15e3
 - Remove check for _quad_keccak stub as that change should be done in separate 
PR.
 - Use AND predicates in multi-block intrinsic tests in case a VM setting makes 
stubs silently unavailable.
 - Remove and block tiered compilation from SHA3 parallel tests as that 
conflicts with compile threshold setting.
 - Fix some more bugs and cleanup VM flag usage.
 - Merge branch 'master' into user/missa-prime/crypto
 - Merge tag 'jdk-28+23' into user/missa-prime/crypto
   
   Added tag jdk-28+23 for changeset 2e25332f
 - Correct SHA512 multi-block intrinsic reference to SHA1 intrinsic source 
tests.
 - Remove unnecessary buffers passed into keccak methods in invocation tests.
 - ... and 4 more: https://git.openjdk.org/jdk/compare/f06e15e3...0647387b

-------------

Changes: https://git.openjdk.org/jdk/pull/33709/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=33709&range=07
  Stats: 450 lines in 9 files changed: 369 ins; 20 del; 61 mod
  Patch: https://git.openjdk.org/jdk/pull/33709.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/33709/head:pull/33709

PR: https://git.openjdk.org/jdk/pull/33709

Reply via email to