On Mon, 2 Nov 2026 17:27:28 GMT, Weijun Wang <[email protected]> wrote:
>> Timofei Fedotov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update license test
>
> test/jdk/sun/security/ec/ed/EmptyEncodedPoint.java line 40:
>
>> 38: byte[] encoded = HexFormat.of().parseHex("300a30050603" +
>> oid + "030100");
>> 39: try {
>> 40: KeyFactory.getInstance("EdDSA").generatePublic(new
>> X509EncodedKeySpec(encoded));
>
> Maybe only check the "SunEC" provider?
Done.
> test/jdk/sun/security/ec/ed/EmptyEncodedPoint.java line 47:
>
>> 45: var pair =
>> KeyPairGenerator.getInstance(algorithm).generateKeyPair();
>> 46: KeyFactory.getInstance(algorithm).generatePublic(new
>> X509EncodedKeySpec(pair.getPublic().getEncoded()));
>> 47: }
>
> Not necessary to include this. Should be covered in other tests.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33641#discussion_r4451236473
PR Review Comment: https://git.openjdk.org/jdk/pull/33641#discussion_r4451236880
