On Mon, 2 Nov 2026 13:09:22 GMT, Tobias Hartmann <[email protected]> wrote:
> Sorry for approving despite the questions/comments - I missed them. No need for an apology. Just wanted to head off a commit of pointless code. > I'm clearly not an expert here but wouldn't this existing code be redundant > as well? Sigh. Yes, those other cases where `CPU_ASIMD` is checked are also redundant and the recent change that modified them is actually based on 3 earlier changes. The earliest one going from 2022 appears to have set a precedent for this unnecessary test. That's the problem when a misguided practice is allowed to start . . . Full disclsoure: I approved at least one of those earlier patches without noticing the error. I'll raise a JIRA to remove these checks. ------------- PR Comment: https://git.openjdk.org/jdk/pull/33661#issuecomment-6580552870
