On Wed, 28 Oct 2026 14:10:20 GMT, Roland Mesde <[email protected]> wrote:
>> src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 121: >> >>> 119: /* >>> 120: * A family is composed of a root session and the sessions that are >>> 121: * derived from its ticket. Sessions that are derived from the >>> tickets of >> >> Nit: I think we should define membership through the copy constructor to >> avoid ambiguity. A server reconstructing a stateless ticket starts a new >> family with depth 0. > > Agreed and that is how it currently works. Only the copy constructor > SSLSessionImpl(SSLSessionImpl, SessionId) joins an existing family. Every > other constructor starts a new family at familyDepth 0. I actually meant `define it in the comment`. Basically, the mechanist introduced with this change is far from being intuitive, I want to make sure we describe it as clear as possible. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33447#discussion_r4402796139
