On Mon, 28 Sep 2026 08:20:59 GMT, Andrew Dinn <[email protected]> wrote:

>> Shawn Emery has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Update based on adinn's comments
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5127:
> 
>> 5125:     // a0..a24 are respective locals from SHA3.java
>> 5126:     RegSetIterator<Register> regs = (RegSet::range(r0, r28) - 
>> r18_tls).begin();
>> 5127:     Register a[25];
> 
> It's worth keeping the comment here and restating it at line 9103
> Suggestion:
> 
>     // a[0]...a[24] correspond to locals a0...a24 from SHA3.java
>     Register a[25];

Done!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33080#discussion_r4127305602

Reply via email to