On Fri, 10 Jul 2026 17:12:51 GMT, Sean Mullan <[email protected]> wrote:

>> This cleans up outdated JKS references in the `keytool` man page.
>> The `jarsigner` man page had the same kind of outdated references, so this 
>> also updates them.
>> 
>> References to JKS as an existing built-in keystore implementation are left 
>> unchanged.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> src/jdk.jartool/share/man/jarsigner.md line 188:
> 
>> 186: proprietary keystore type (format) named `JKS`. It protects each 
>> private key
>> 187: with its individual password, and also protects the integrity of the 
>> entire
>> 188: keystore with a (possibly different) password.
> 
> Let's also remove the last 2 sentences of this paragraph. I don't think we 
> should mention JKS at all, as it is discouraged. Users can always find what 
> other keystore implementations there are via other docs, such as the JDK 
> Providers Guide.

Thanks for your review.

Should we remove the preceding sentence as well?

> There is another built-in implementation, provided by Oracle.

Although the statement is correct, it provides little information on its own 
and would make the paragraph feel abrupt after removing the following two 
sentences.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31740#discussion_r3561891069

Reply via email to