On Thu, 25 Jun 2026 13:05:20 GMT, Artur Barashev <[email protected]> wrote:
>> These mappings were previously missing, causing >> jdk.tls.disabledAlgorithms constraints using component names (e.g. >> "AES_128_GCM", "AES_256_GCM", "CHACHA20_POLY1305") to not >> consistently match the corresponding TLS cipher suites. >> >> >> >> >> --------- >> - [ x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > test/jdk/sun/security/ssl/CipherSuite/TLS13DisableCipherSuite.java line 1: > >> 1: /* > > I find this test name to be too general. How about > `TLS13BulkCipherDisabledCipherSuite`? Same for the other test. Its fine for me > test/jdk/sun/security/ssl/CipherSuite/TLS13DisableCipherSuite.java line 25: > >> 23: >> 24: /* >> 25: * @test > > Please insert `@bug 8387124`, same for the other test. done > test/jdk/sun/security/ssl/CipherSuite/TLS13DisableCipherSuite.java line 26: > >> 24: /* >> 25: * @test >> 26: * @summary Test TLS 1.3 disabled algorithms behavior > > Replace with something like `Test disabling cipher suites with bulk ciphers' > names`? good > test/jdk/sun/security/ssl/CipherSuite/TLS13DisableCipherSuite.java line 38: > >> 36: import java.util.List; >> 37: >> 38: public class TLS13DisableCipherSuite extends AbstractDisableCipherSuites >> { > > This test actually runs on TLSv1.2 by default. Please override > `getProtocol()` method of the base class to make it run on TLSv1.3 so we test > disabling TLSv1.3-specific cipher suites correctly. done > test/jdk/sun/security/ssl/CipherSuite/TLS13DisabledAlgorithm.java line 2: > >> 1: /* >> 2: * Copyright (c) 2015, 2026, Oracle and/or its affiliates. All rights >> reserved. > > Is this a brand new test of you re-used some of the Oracle's code? Please > correct the copyright if it's a brand new test. its a brand new test. My mistake :) > test/jdk/sun/security/ssl/CipherSuite/TLS13DisabledAlgorithm.java line 26: > >> 24: /* >> 25: * @test >> 26: * @summary Test TLS 1.3 disabled algorithms behavior > > Please update the summary like in the other test. done > test/jdk/sun/security/ssl/CipherSuite/TLS13DisabledAlgorithm.java line 33: > >> 31: >> 32: import java.net.InetAddress; >> 33: import java.security.Security; > > Unused import done ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31633#discussion_r3476351060 PR Review Comment: https://git.openjdk.org/jdk/pull/31633#discussion_r3476340241 PR Review Comment: https://git.openjdk.org/jdk/pull/31633#discussion_r3476356961 PR Review Comment: https://git.openjdk.org/jdk/pull/31633#discussion_r3476368411 PR Review Comment: https://git.openjdk.org/jdk/pull/31633#discussion_r3476384123 PR Review Comment: https://git.openjdk.org/jdk/pull/31633#discussion_r3476374997 PR Review Comment: https://git.openjdk.org/jdk/pull/31633#discussion_r3476371952
