On Thu, 26 Mar 2026 01:09:58 GMT, Weijun Wang <[email protected]> wrote:

>> Add export function to HPKE. New tests added.
>> 
>> Note that this PR does not compile without 
>> https://github.com/openjdk/jdk/pull/18409, even if they are touching 
>> different files.
>
> Weijun Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   npe test

Couple of comments. I think this needs a CSR because even though it is already 
implemented, you are now exposing it via a public API. I think a release note 
should also be added.

Did you consider combining this with 
https://bugs.openjdk.org/browse/JDK-8325513? Seems like it would be easier to 
treat as one issue with one CSR, one release note.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30146#issuecomment-4137598359

Reply via email to