On Wed, 4 Mar 2026 19:12:48 GMT, Ben Perez <[email protected]> wrote:

>> Our implementation of X25519 does not zero the MSB of the `u` coordinate as 
>> required by RFC 7748. Currently the test 
>> `jdk/sun/security/ec/xec/TestXDH.java` zeroes the bit manually while parsing 
>> test vectors, which is likely why this went uncaught.
>
> Ben Perez has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   removed wildcard imports

test/jdk/sun/security/ec/xec/TestXECOps.java line 131:

> 129:     }
> 130: 
> 131:     private void runTest(String opName, String k_in_str,

You should probably also add the multiply-with-bigint check in this method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29750#discussion_r2885724582

Reply via email to