On Mon, 2 Mar 2026 11:49:04 GMT, Mikhail Yankelevich <[email protected]>
wrote:
>> Ben Perez has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changed params comparison
>
> test/lib/jdk/test/lib/Convert.java line 50:
>
>> 48: */
>> 49: public static
>> 50: BigInteger hexStringToBigInteger(boolean clearHighBit, String str) {
>
> Do you think this should have been removed all together? Wouldn't it make
> sense to leave this in and call in `TestXDH` with `clearHighBit == false`?
> This way the conversion utility method still stays.
I'm definitely open to that - this is just the only caller and the
`clearHighBit` functionality only really makes sense for X25519 so it seemed
like it'd be simpler to remove entirely and do the conversion directly in the
test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29750#discussion_r2874644997
