On Fri, 27 Feb 2026 03:42:09 GMT, Shawn Emery <[email protected]> wrote:
>> xinyangwu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8376164: Optimize AES/ECB/PKCS5Padding implementation using full-message >> intrinsic stub and parallel RoundKey addition > > src/hotspot/cpu/x86/stubGenerator_x86_64_aes.cpp line 1497: > >> 1495: >> 1496: load_key(xmm_key_tmp, key, 0x00, xmm_key_shuf_mask); >> 1497: DoFour(pxor, xmm_key_tmp); > > Can the `DoFour()` and `DoOne()` sequences have only only one instance, where > there would be two conditionals for each of the other two key lengths? It > seems that this would eliminate a lot of duplication that could easily fit > into this design pattern, similar to how the software block cipher is > implemented ;) Great suggestion! I refactored the code following the pattern used in the CTR decryption parallel implementation, and it does look much cleaner now with much less duplication. Thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29385#discussion_r2866928175
