On Thu, 26 Feb 2026 14:30:33 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this test-only change which removes the >> reference to the obsolete `jdk.net.usePlainSocketImpl` property? >> >> `jdk.net.usePlainSocketImpl` was removed in >> https://bugs.openjdk.org/browse/JDK-8253119 and plays no role anymore in the >> JDK. This `test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketReset.java` test >> was introduced to reproduce a bug in the implementation of PlainSocketImpl, >> but doesn't rely on any internal socket implementation details, so I think >> it should be OK to retain this test and just remove the usage of the >> property. The property has been playing no role in this test, and the test >> has been functional, ever since the property was removed in JDK-8253119. > > Jaikiran Pai has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - Sean's review - use othervm > - merge latest from master branch > - merge latest from master branch > - 8378379: Remove reference to obsolete jdk.net.usePlainSocketImpl property > from SSLSocketReset test LGTM ------------- Marked as reviewed by coffeys (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29872#pullrequestreview-3861353626
