On Fri, 16 Jan 2026 17:56:42 GMT, Weijun Wang <[email protected]> wrote:
>> Roger Calnan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> updates from feedback
>
> src/java.base/share/man/keytool.md line 1591:
>
>> 1589: The command creates the keystore named `mykeystore` in the working
>> directory
>> 1590: (provided it doesn't already exist), and assigns it the password
>> specified by
>> 1591: [`-keypass`]{#-keypass}. It generates a public/private key pair for
>> the entity whose
>
> I'd rather not giving this an anchor. It just happens to be mentioned here.
> It's not the formal spec for it.
yes, that is a mistake removed
> src/java.base/share/man/keytool.md line 2366:
>
>> 2364: that don't conform to the standard might be rejected by the JDK or
>> other
>> 2365: applications. Users should ensure that they provide the correct
>> options for
>> 2366: [`-dname`]{#-dname}, `-ext`, and so on.
>
> Same for this one. No need to add an anchor here.
removed
> src/jdk.jartool/share/man/jarsigner.md line 800:
>
>> 798: path-separator character.
>> 799:
>> 800: [`-J`]{#-J}*javaoption*
>
> Maybe this one is not necessary. It's a general option for extra VM options.
removed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29258#discussion_r2699612707
PR Review Comment: https://git.openjdk.org/jdk/pull/29258#discussion_r2699613094
PR Review Comment: https://git.openjdk.org/jdk/pull/29258#discussion_r2699611754
