On Tue, 9 Dec 2025 18:19:04 GMT, Volodymyr Paprotski <[email protected]>
wrote:
>> …hould pass on Aarch64
>>
>> The test used to fail because it had checked a stronger equivalence of the
>> results of the Java method and its intrinsified version.
>> Other then fixing that, I did some formatting and corrected a comment.
>
> test/jdk/sun/security/provider/pqc/ML_DSA_Intrinsic_Test.java line 147:
>
>> 145:
>> 146: if (!Arrays.equals(prod1, prod2)) {
>> 147: boolean modQequal = true;
>
> I would probably had moved this to its own helper `arraysCongruent` and
> replaces the `if (!Arrays.equals(prod1, prod2))` with
> `!arraysCongruent(prod1, prod2)`. But not a deal-breaker..
Thanks for your thorough review and comments!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28722#discussion_r2614097633
