On Fri, 21 Feb 2025 16:40:08 GMT, Ben Perez <[email protected]> wrote:
>> 8261513: Various BasicConstraintsExtension issues
>
> Ben Perez has updated the pull request incrementally with one additional
> commit since the last revision:
>
> changed toString wording, no longer set critical to ca
src/java.base/share/classes/sun/security/x509/BasicConstraintsExtension.java
line 1:
> 1: /*
Why don't we have a unit test for these changes?
src/java.base/share/classes/sun/security/x509/BasicConstraintsExtension.java
line 166:
> 164: public String toString() {
> 165: String pathLenAsString;
> 166: if (pathLen < 0 || pathLen == Integer.MAX_VALUE) {
What's the practical difference between `-1` and `Integer.MAX_VALUE`? Should we
set the default value of `pathlen` to `Integer.MAX_VALUE` to simplify things?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20224#discussion_r2504740883
PR Review Comment: https://git.openjdk.org/jdk/pull/20224#discussion_r2504738436
