On Tue, 4 Nov 2025 14:22:15 GMT, Neha Joshi <[email protected]> wrote:
>> This PR contain changes to handle skipped exception for below test cases. >> >> -> test/jdk/java/security/cert/CertStore/NoLDAP.java >> -> test/jdk/java/security/Provider/NewInstance.java >> >> >> https://bugs.openjdk.org/browse/JDK-8370942 > > Neha Joshi has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8370942 : Remove the skip provider from the list. Looks good to me test/jdk/java/security/Provider/NewInstance.java line 49: > 47: public static void main(String[] args) throws Exception { > 48: > 49: System.out.println("Removing SunPCSC provider from the list (A > smartcard might not be installed)."); Nit: I'd keep it a comment, but print is fine imo too ------------- Marked as reviewed by myankelevich (Committer). PR Review: https://git.openjdk.org/jdk/pull/28112#pullrequestreview-3417058537 PR Review Comment: https://git.openjdk.org/jdk/pull/28112#discussion_r2490942456
