On Tue, 4 Nov 2025 02:07:51 GMT, SendaoYan <[email protected]> wrote: >> Neha Joshi has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8370942 : Reveiw comment fixes. > > test/jdk/java/security/cert/CertStore/NoLDAP.java line 39: > >> 37: try { >> 38: Class.forName("javax.naming.ldap.LdapName"); >> 39: System.out.println("LDAP is present, test skipped"); > > Maybe we can add a new line to throw a Exception when the expected > ClassNotFoundException do not seen. > > > throw new RuntimeException("The expexted ClassNotFoundException was not > observed.");
I'm not sure this would work tbh. This is an optional setting and failing the test due to the machine being setup for other tests may just introduce the noise from a false negative result. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28112#discussion_r2489244707
