On Tue, 28 Oct 2025 21:58:00 GMT, Anthony Scarpino <[email protected]> wrote:
>> test/jdk/java/security/cert/CertPathBuilder/selfIssued/KeyUsageMatters.java >> line 202: >> >>> 200: >>> 201: // generate certificate from certificate string >>> 202: DEREncodable cert = PEM_DECODER.decode(targetCertStr, >>> X509Certificate.class); >> >> nit: there is little value storing the decode() in a variable that is then >> added to `entries()`. You could do `entries.add(PEM_DECODER...)` > > Note: there are a lot of these situation in the PR. I'm fine if these are > not changed, but I wanted to bring it to your attention. Changed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27267#discussion_r2475422341
