On Fri, 24 Oct 2025 20:28:35 GMT, Anthony Scarpino <[email protected]> wrote:
>> The following tests have been identified as candidates for phase 1 of this >> change. >> 2. test/jdk/javax/net/ssl/TLSCommon/TLSTest.java >> 3. test/jdk/sun/security/provider/certpath/DisabledAlgorithms/CPBuilder.java >> 4. >> test/jdk/sun/security/provider/certpath/DisabledAlgorithms/CPBuilderWithMD5.java >> 5. >> test/jdk/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorEndEntity.java >> 9. >> test/jdk/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorIntermediate.java >> 10. test/jdk/sun/security/ssl/X509TrustManagerImpl/PKIXExtendedTM.java >> 11. test/jdk/sun/security/ssl/X509TrustManagerImpl/SunX509ExtendedTM.java >> 13. >> test/jdk/java/security/cert/CertPathBuilder/selfIssued/KeyUsageMatters.java >> 16. >> test/jdk/java/security/cert/CertPathBuilder/selfIssued/DisableRevocation.java >> 17. >> test/jdk/java/security/cert/CertPathValidator/indirectCRL/CircularCRLOneLevel.java >> 18. >> test/jdk/java/security/cert/CertPathValidator/indirectCRL/CircularCRLOneLevelRevoked.java >> 20. test/jdk/java/security/KeyStore/PKCS12/WriteP12Test.java >> 21. test/jdk/java/security/cert/CertPathValidator/OCSP/FailoverToCRL.java >> 22. >> test/jdk/java/security/cert/CertPathValidator/nameConstraints/NameConstraintsWithRID.java >> 23. >> test/jdk/java/security/cert/CertPathValidator/nameConstraints/NameConstraintsWithUnexpectedRID.java >> 24. >> test/jdk/java/security/cert/CertPathValidator/nameConstraints/NameConstraintsWithoutRID.java >> 25. >> test/jdk/java/security/cert/CertPathValidator/trustAnchor/ValWithAnchorByName.java >> 30. test/jdk/java/security/KeyStore/TestKeyStoreBasic.java > > test/jdk/java/security/cert/CertPathBuilder/selfIssued/KeyUsageMatters.java > line 202: > >> 200: >> 201: // generate certificate from certificate string >> 202: DEREncodable cert = PEM_DECODER.decode(targetCertStr, >> X509Certificate.class); > > nit: there is little value storing the decode() in a variable that is then > added to `entries()`. You could do `entries.add(PEM_DECODER...)` Note: there are a lot of these situation in the PR. I'm fine if these are not changed, but I wanted to bring it to your attention. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27267#discussion_r2471172300
