On Wed, 1 Oct 2025 16:50:16 GMT, Anthony Scarpino <[email protected]> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more key checks; some small spec change > > src/java.base/share/classes/com/sun/crypto/provider/DHKEM.java line 31: > >> 29: import java.io.Serial; >> 30: import java.math.BigInteger; >> 31: import java.security.AsymmetricKey; > > Since your original putback used import java.security.* and others below, was > it your intent to specify 11 java.security class instead of using a wildcard, > or did the IDE do this? Not the IDE, but I keep hearing people saying wildcard import is evil. > src/java.base/share/classes/com/sun/crypto/provider/HPKE.java line 225: > >> 223: } >> 224: >> 225: //@Override > > Do you need this comment here and the next method below? Yes, so when JDK-8325513: Export method for Cipher is integrated, I only need to uncomment this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2467073372 PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2467078578
