On Fri, 3 Oct 2025 17:47:41 GMT, Anthony Scarpino <[email protected]> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> more key checks; some small spec change
>
> src/java.base/share/classes/com/sun/crypto/provider/HPKE.java line 452:
>
>> 450: private static void checkMatch(boolean inSpec, AsymmetricKey k,
>> int kem_id)
>> 451: throws InvalidKeyException,
>> InvalidAlgorithmParameterException {
>> 452: var p = k.getParams();
>
> nit: It looks like you could have used a `switch (k.params())` here.
There are also other candidates for switch in `Impl.init()` and `engineInit()`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2403038528
