On Thu, 14 Aug 2025 17:24:57 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> One known user of HPKE -- [Encrypted 
>> ClientHello](https://datatracker.ietf.org/doc/html/draft-ietf-tls-esni-25#name-offering-ech)
>>  -- uses `"tls ech" || 0x00 || ECHConfig` and it's binary (at least you see 
>> an 0x00 there).
>
> In fact, if I output a string format here, I would rather only do it for pure 
> ASCII strings. Some Unicode characters are just not distinguishable from 
> human eyes. Then the check can be very simple.
> 
> Do you prefer showing both? I mean, info=41424344 ("ABCD").

I see. Yes, ASCII (together with hex) should be fine. Let's also change `info` 
encoding from `UTF_8` to `US_ASCII` in tests as well. My main concert was 
readability of `info` in tests when we print `HPKEParameterSpec`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18411#discussion_r2277344709

Reply via email to