On Wed, 30 Jul 2025 17:35:04 GMT, Artur Barashev <abaras...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments from Sean and Tony.
>
> src/java.base/share/conf/security/java.security line 784:
>
>> 782: #
>> 783: # The syntax of the disabled services string is described as follows:
>> 784: # "DisabledService {, DisabledService}"
>
> `DisabledService` looks rather confusing in this context, should we replace
> it with `DisabledAlgorithm`?
Well, each component is not just algorithm, but also the service which
algorithm is for. This is different from other security properties whose values
are algorithms only (and some constraints). Thus I didn't use the
`DisabledAlgorithm` name.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26377#discussion_r2244385403
