On Fri, 27 Jun 2025 09:49:44 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 525 commits: >> >> - merge latest changes from master branch >> - http3: run H3StreamLimitReachedTest.java with >> -Djdk.httpclient.http3.maxStreamLimitTimeout=0 too >> - retry the ResetControlStream test as needed >> - http3: fix pending connection and reconnection on stream limit reached >> logic >> - http3: pending acknowledgement should be registered before actually >> sending the packet >> - http3: fix race with ping requests in PacketSpaceManager.java causing >> intermittent failures in H3ErrorHandlingTest.java >> - http3: improve exceptions in Http3ServerExchange.java >> - http3: fix exception handling in CancelRequestTest.java >> - http3: review feedback - revert HPACK.java >> - Implement X509TrustManagerImpl#checkClientTrusted for QUIC >> - ... and 515 more: https://git.openjdk.org/jdk/compare/5a1301df...0229c215 > > src/java.base/share/classes/sun/security/ssl/QuicTransportParametersExtension.java > line 37: > >> 35: /** >> 36: * QuicTransportParametersExtension is an implementation of RFC 9000. >> 37: * It is only used by QUIC connections. > > I believe referencing RFC 9001 Section 8.2 would be more appropriate here. > The QUIC transport parameters themselves are defined in RFC 9000, but the use > of the quic_transport_parameters extension in the ClientHello and the > EncryptedExtensions messages is described in RFC 9001. > Or else the purpose and description of this class could be clarified. Most of the extensions have a generic JavaDoc, I will update this one to match the others. > src/java.base/share/classes/sun/security/ssl/SSLExtension.java line 461: > >> 459: KeyShareExtension.hrrStringizer), >> 460: >> 461: // Extension defined in RFC 9000 > > Shouldn't this be RFC 9001 here too? Will be updated in the next refresh. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2174477328 PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2174479150
