On Fri, 27 Jun 2025 11:37:00 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 525 commits: >> >> - merge latest changes from master branch >> - http3: run H3StreamLimitReachedTest.java with >> -Djdk.httpclient.http3.maxStreamLimitTimeout=0 too >> - retry the ResetControlStream test as needed >> - http3: fix pending connection and reconnection on stream limit reached >> logic >> - http3: pending acknowledgement should be registered before actually >> sending the packet >> - http3: fix race with ping requests in PacketSpaceManager.java causing >> intermittent failures in H3ErrorHandlingTest.java >> - http3: improve exceptions in Http3ServerExchange.java >> - http3: fix exception handling in CancelRequestTest.java >> - http3: review feedback - revert HPACK.java >> - Implement X509TrustManagerImpl#checkClientTrusted for QUIC >> - ... and 515 more: https://git.openjdk.org/jdk/compare/5a1301df...0229c215 > > src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java line 121: > >> 119: } >> 120: >> 121: // Keeps track of the underlying connection when establishing an >> HTTP/2 > > since this is now used with HTTP/3, should we update this comment? I have verified the other comments in this class and updated to mention or HTTP/3 in a few places in this class, in my local repo. Will appear the next time I sync this PR. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2171978343
