On Thu, 26 Jun 2025 21:36:34 GMT, Artur Barashev <abaras...@openjdk.org> wrote:
> DESCRIPTION OF THE PROBLEM: > There appears to be a bug in the isCookieValid method of HelloCookieManager > that can lead to improper cookie validation results after a new cookieSecret > is generated. The cookie version (cookieVersion) is initialized with a random > number and increments with each cookie, regenerating the secret every > 0xFFFFFF cookies. > > When cookieVersion is negative, the expression ((cookieVersion >> 24) & 0xFF) > results in an integer that does not match the signed byte value in cookie[0], > causing the else clause to be executed incorrectly. This leads to the use of > legacySecret even for valid cookies. The change looks good. ------------- Marked as reviewed by ascarpino (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26006#pullrequestreview-2963938328
