On Fri, 30 May 2025 14:23:24 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Volkan Yazici has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Provide fallback for `stdin.encoding`
>> - Revert changes to `Application` and `JavaChild`
>>
>> There stdin is connected to the parent process rather than the console.
>
> test/jdk/com/sun/tools/attach/Application.java line 40:
>
>> 38:
>> 39: try (BufferedReader br = new BufferedReader(new
>> InputStreamReader(
>> 40: System.in, System.getProperty("stdin.encoding")))) {
>
> This "application" is launched by the test so connected to the parent process
> rather than the console.
Reverted in 2d52ba408.
> test/jdk/java/lang/ProcessHandle/JavaChild.java line 315:
>
>> 313: // children and wait for each to exit
>> 314: sendResult(action, "start");
>> 315: try (Reader reader = new
>> InputStreamReader(System.in, System.getProperty("stdin.encoding"));
>
> I didn't study the test closely but I think this is another case where a
> child process is launched so System.in is connected to the parent rather than
> the console.
Reverted in 2d52ba408..
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25544#discussion_r2121978546
PR Review Comment: https://git.openjdk.org/jdk/pull/25544#discussion_r2121978885
