On Fri, 9 May 2025 23:46:27 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - comments
>> - toString update
>> - non-sealed
>> Better X509 KeyPair parsing
>
> src/java.base/share/classes/java/security/PEMRecord.java line 51:
>
>> 49: * reached the end of the stream. If there is PEM data, {@code type} and
>> 50: * {@code pem} will both be non-null. {@code leadingData} may be null if
>> the
>> 51: * input data only contains PEM data. All values can never be null.
>
> It feels like the 2 paragraphs above should be in the spec of
> `Decoder::decode`. Here we only need to say what fields can be null.
ok
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r2086248007
