On Mon, 12 May 2025 17:07:57 GMT, Roger Riggs <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Prefixed `JavaLangAccess::stringConcat1` with `unchecked`
>> - Fix `HexDigits` copyright year
>
> src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 328:
>
>> 326: * {@linkplain java.nio.charset.Charset charset}.
>> 327: * <p>
>> 328: * <b>WARNING: This method return the {@code byte[]} backing the
>> provided
>
> Suggestion:
>
> * <b>WARNING: This method returns the {@code byte[]} backing the provided
>
> Should this more explicitly say the returned byte array must not be modified?
Improved as suggested in cd156fbab46.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24982#discussion_r2085329577
