On Wed, 7 May 2025 17:02:26 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Koushik Muthukrishnan Thirupattur has updated the pull request incrementally >> with one additional commit since the last revision: >> >> 8310003: Improve logging when default truststore is inaccessible > > src/java.base/share/classes/sun/security/ssl/TrustStoreManager.java line 133: > >> 131: KeyStore.getDefaultType()); >> 132: String storePropProvider = System.getProperty( >> 133: "javax.net.ssl.trustStoreProvider", "unspecified"); > > We only want "unspecified" to show up in the log message. This code will set > the provider to "unspecified" (if not set) when later instantiating a > `TrustManager`, which is not what we want to happen. > > Only line 115 should probably be changed. You can do something like: > >> "trustStore provider is: " + (storeProvider == null ? "unspecified" : >> storeProvider) + "\n" + I see, I misunderstood our conversation. Changed it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25077#discussion_r2078102147
