On Wed, 2 Apr 2025 12:51:42 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:

>> Disable SHA-1 in TLS/DTLS 1.2 handshake signatures (but not in certificate 
>> signatures).
>> https://www.rfc-editor.org/rfc/rfc9155.html
>
> test/jdk/sun/security/ssl/SignatureScheme/DisableSHA1inHandshakeSignatureDTLS12.java
>  line 34:
> 
>> 32:  */
>> 33: 
>> 34: import java.lang.Override;
> 
> You shouldn't have to import java.lang.Override

Indeed, thanks! For some reason my IntelliJ inserts this import on "Optimize 
Imports" command, I need to find out why.

> test/jdk/sun/security/ssl/SignatureScheme/DisableSHA1inHandshakeSignatureTLS12.java
>  line 37:
> 
>> 35: import static jdk.test.lib.Asserts.assertTrue;
>> 36: 
>> 37: import java.lang.Override;
> 
> unnecessary import

Replied above.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24367#discussion_r2025147866
PR Review Comment: https://git.openjdk.org/jdk/pull/24367#discussion_r2025148344

Reply via email to