On Tue, 11 Mar 2025 16:53:17 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:
>> In this PR, I created a new method, `ArtifactResolver.fetchOne()`, to
>> consolidate duplicate code across tests.
>
> Matthew Donovan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Changed exception message in Artifact resolver and fixed logic in keytool
> test
test/jdk/sun/security/pkcs11/PKCS11Test.java line 718:
> 716: }
> 717:
> 718: private static Path fetchNssLib(String osId, Path libraryName)
> throws IOException {
Is the `IOException` caught later and wrapped as a `SkippedException`?
test/lib/jdk/test/lib/artifacts/ArtifactResolver.java line 103:
> 101: message = "Cannot find the artifact " + artifact.name();
> 102: } else {
> 103: message = "Class " + klass.getName() + " missing
> @Artifact annotation.";
I assume it's a bug if `klass` is not annotated with `@Artifact`. I'd rather
throw an NPE here so we can notice it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23989#discussion_r1991504637
PR Review Comment: https://git.openjdk.org/jdk/pull/23989#discussion_r1991512616
