On Mon, 3 Mar 2025 16:26:21 GMT, Weijun Wang <wei...@openjdk.org> wrote:

> Loosen the check; the modified test is sufficient to demonstrate 
> sub-millisecond precision.

test/jdk/sun/security/krb5/MicroTime.java line 49:

> 47:         // Before this change, KerberosTime was implemented in 
> milliseconds.
> 48:         // Now there should be more.
> 49:         if (count < 1001) {

Why 1001 and not 1000?

test/jdk/sun/security/krb5/MicroTime.java line 50:

> 48:         // Now there should be more.
> 49:         if (count < 1001) {
> 50:             throw new Exception("What? only " + (1000000/count) +

Shouldn't we add a zero to "1000000/count" as well to account for the measured 
precision change?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23867#discussion_r1977988750
PR Review Comment: https://git.openjdk.org/jdk/pull/23867#discussion_r1977988447

Reply via email to