On Fri, 10 Jan 2025 10:27:50 GMT, Shivangi Gupta <[email protected]> wrote:
>> test/jdk/com/sun/security/auth/callback/TextCallbackHandler/Password.java
>> line 53:
>>
>>> 51:
>>> 52: if (System.getProperty("java.class.path").contains("jtreg")){
>>> 53: throw new RuntimeException("This is a manual testing, it
>>> shouldn't be run with jtreg.");
>>
>> Was a crash necessary ? Can't we bail out ?
>
> I think it is good to put. As this the manual test and ran by IMT. They are
> raising issue if the test is failing and actually not going inside the test
> and checking the steps how to run. As they run all the test using jtreg they
> will just trigger in bunch. So if we give proper message that "this test will
> failing while running jtreg , please go and see the steps inside the test to
> run" will be good
Thank you, I'll leave it in order to raise an issue. I will also change the
wording a bit, to fix the grammar a bit
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22951#discussion_r1910294245
