On Tue, 19 Nov 2024 20:43:25 GMT, Sean Mullan <mul...@openjdk.org> wrote:
> Now that JEP 486 has been integrated, `java.security.jgss` and
> `jdk.security.jgss` module dependencies on `System.getSecurityManager` and
> `AccessController.doPrivileged*` can be removed.
>
> There is an undocumented property named "sun.security.krb5.autodeducerealm"
> that can probably be removed as it only affected behavior when an SM was
> enabled; however I have left the code that reads the property as-is (see
> sun/security/krb5/Realm.java) and have opened a separate issue to determine
> if it can be safely removed.
src/java.security.jgss/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java
line 115:
> 113: }
> 114: Oid[] mechs = GSSLibStub.indicateMechs();
> 115: HashMap<String,String> map = new HashMap<>();
Suggestion:
HashMap<String, String> map = new HashMap<>();
src/java.security.jgss/share/classes/sun/security/krb5/KdcComm.java line 349:
> 347: DEBUG.println(">>> KDCCommunication: kdc=" + kdc
> 348: + " " + proto + ":"
> 349: + port + ", timeout="
Suggestion:
+ port + ", timeout="
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22256#discussion_r1851454369
PR Review Comment: https://git.openjdk.org/jdk/pull/22256#discussion_r1851453729
