On Wed, 20 Nov 2024 13:53:23 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove the empty lines added
>
> test/jdk/javax/net/ssl/SSLEngine/Basics.java line 60:
>
>> 58:
>> 59: public static void main(String[] args) throws Exception {
>> 60: SecurityUtils.removeFromDisabledTlsAlgs("TLSv1.1", "TLS_RSA_*");
>
> Add comment: // Re-enable TLSv1.1 and TLS_RSA_* since test depends on it.
Done
> test/jdk/javax/net/ssl/SSLEngine/EngineCloseOnAlert.java line 66:
>
>> 64:
>> 65: public static void main(String[] args) throws Exception {
>> 66: SecurityUtils.removeFromDisabledTlsAlgs("TLS_RSA_*");
>
> Add comment: // Re-enable TLS_RSA_* since test depends on it.
Done.
> test/jdk/javax/net/ssl/TLSv11/GenericBlockCipher.java line 175:
>
>> 173:
>> 174: public static void main(String[] args) throws Exception {
>> 175: // Re-enable TLSv1.1 since test depends on it.
>
> Update comment: s/TLSv1/TLSv1 and TLS_RSA_*/
Done.
> test/jdk/javax/net/ssl/TLSv12/ProtocolFilter.java line 162:
>
>> 160:
>> 161: public static void main(String[] args) throws Exception {
>> 162: SecurityUtils.removeFromDisabledTlsAlgs("TLS_RSA_*");
>
> Add comment: // Re-enable TLS_RSA_* since test depends on it.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22163#discussion_r1850540616
PR Review Comment: https://git.openjdk.org/jdk/pull/22163#discussion_r1850543032
PR Review Comment: https://git.openjdk.org/jdk/pull/22163#discussion_r1850544864
PR Review Comment: https://git.openjdk.org/jdk/pull/22163#discussion_r1850546656
