On Mon, 18 Nov 2024 20:56:59 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8344446: Address review comments >> - 8344446: Remove security manager dependency from module jdk.sctp > > src/java.base/share/classes/java/io/Console.java line 660: > >> 658: } >> 659: >> 660: @SuppressWarnings("removal") > > This too Removed in c7ba335. > src/java.base/share/classes/java/io/Console.java line 687: > >> 685: } >> 686: } catch (ServiceConfigurationError _) { >> 687: c = null; > > This assignment can be removed Removed in c7ba335. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22219#discussion_r1847275215 PR Review Comment: https://git.openjdk.org/jdk/pull/22219#discussion_r1847275162