On Sat, 16 Nov 2024 02:48:09 GMT, John R Rose <jr...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains nine commits:
>>
>> - Handle merge conflicts in new resolve_instance_class calls.
>> - Merge branch 'master' into protection-domain
>> - Purge last references to SecurityManager.
>> - More obsolete code. Fix trace_class_resolution (doesn't throw exception
>> - shouldn't take TRAPS).
>> - Found more obsolete security manager code.
>> - More purging of AccessController, AccessControlContext and some
>> stackwalking questions.
>> - David comments.
>> - Remove some more includes.
>> - 8341916: Remove ProtectionDomain related hotspot code and tests
>
> src/hotspot/share/prims/jvm.cpp line 169:
>
>> 167: while (!vfst.at_end()) {
>> 168: Method* m = vfst.method();
>> 169: if
>> (!vfst.method()->method_holder()->is_subclass_of(vmClasses::ClassLoader_klass()))
>> {
>
> We are no longer skipping AC frames, but user code will continue to use AC
> calls, even if they are silly. Will this affect any existing
> caller-sensitive calculations? The failure mode would be that a
> "get-caller-class" query would return AC.class, not the caller of the AC
> method.
(Wait, I think my comment is in the wrong place. This is just tracing code,
but I thought I saw a similar change for the general walker code…)
Right, cancel the previous comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22064#discussion_r1844892667
